Skip to content

chore(manifest): bump SHA after #83 (extract-plan JSONL)#84

Merged
YiWang24 merged 1 commit into
mainfrom
chore/bump-after-83
May 4, 2026
Merged

chore(manifest): bump SHA after #83 (extract-plan JSONL)#84
YiWang24 merged 1 commit into
mainfrom
chore/bump-after-83

Conversation

@YiWang24

@YiWang24 YiWang24 commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Final SHA bump for #81 fix.


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow implementations across CI/CD pipeline, including agent validation, testing, integration, deployment, documentation, and release processes. All job configurations and secrets remain unchanged.

@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@YiWang24 YiWang24 merged commit 8979233 into main May 4, 2026
14 of 15 checks passed
@YiWang24 YiWang24 deleted the chore/bump-after-83 branch May 4, 2026 17:56
@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d821457e-39b5-4cdb-ac2f-a1a320476da6

📥 Commits

Reviewing files that changed from the base of the PR and between cd1b427 and 991834e.

📒 Files selected for processing (13)
  • .github/workflows/agent.yml
  • .github/workflows/ci-self-test.yml
  • .github/workflows/ci.yml
  • .github/workflows/dependencies.yml
  • .github/workflows/deploy.yml
  • .github/workflows/docs.yml
  • .github/workflows/issue-ops.yml
  • .github/workflows/observability.yml
  • .github/workflows/on-maintenance.yml
  • .github/workflows/pull-request.yml
  • .github/workflows/release.yml
  • .github/workflows/reusable-ci.yml
  • manifest.yml

📝 Walkthrough

Walkthrough

All GitHub Actions workflow files (agent, ci-self-test, ci, dependencies, deploy, docs, issue-ops, observability, on-maintenance, pull-request, release) and the manifest are updated to pin external reusable workflows and actions to a new commit SHA (cd1b427370ebacb56cc9c0b418d6d8985c9be539) instead of the previous one (f62931bd0e2b73800512625a9fc5118557957ff3).

Changes

Unified OpenCI Dependency Pin Update

Layer / File(s) Summary
Manifest Dependency Declaration
manifest.yml
deps.YiAgent/OpenCI is updated from f62931bd... to cd1b427..., establishing the new pinned reference for the vendored OpenCI infrastructure.
External Reusable Workflow Calls
.github/workflows/agent.yml, ci-self-test.yml, ci.yml, dependencies.yml, deploy.yml, docs.yml, issue-ops.yml, observability.yml, on-maintenance.yml, pull-request.yml, release.yml
Each workflow file updates its jobs.*.uses: reference to reusable workflows (e.g., reusable-agent.yml, reusable-pr.yml, reusable-prd.yml) from the old SHA to the new SHA. All job inputs and secrets mappings remain unchanged.
Internal Action References
.github/workflows/reusable-ci.yml
Eight instances of the internal composite action YiAgent/OpenCI/actions/_common/resolve-openci are updated from the old SHA to the new SHA across multiple jobs (Preflight, Detect Language, Build Docker, Scan Image, Sign Image, Check Migration, AI Smoke Eval, CI Failure Analyst).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Whiskers twitching at the pins,
New commits flow through our workflows thin,
From old SHA to the fresh one clear,
CI gardens bloom throughout the year!
A hop, a pin, a unified hash—
Our infrastructure dances in a dash!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-after-83

Review rate limit: 8/10 reviews remaining, refill in 10 minutes and 12 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

OpenCI issue agent executed:

  • escalate: needs-human

Reasoning:
Agent output did not contain a parseable action plan.

YiWang24 added a commit that referenced this pull request May 4, 2026
The workflow audit added in #84-era (commit 4415cb2) introduced bats
tests that were already failing on main when authored:

- `reusable workflow names match filenames` — `name:` field in
  `reusable-agent.yml` (claude-harness) and `reusable-deps.yml`
  (dep-auto-merge) didn't reference the filename suffix.
- `workflow requests security-events: write permission` —
  `ci-self-test.yml` permissions block was missing
  `security-events: write`.
- `auditor is clean against the live repository` —
  workflow-audit.sh rule W03 flagged `reusable-release.yml` for
  redeclaring the caller's `concurrency.group` (deadlock risk per
  issue #68).

Fixes:
- Rename `name:` to `reusable-agent` / `reusable-deps`.
- Add `security-events: write` to ci-self-test.yml permissions.
- Drop the `concurrency:` block from `reusable-release.yml` and
  leave the caller (release.yml) as the sole owner of the group.

All 719 bats tests now pass.
YiWang24 added a commit that referenced this pull request May 4, 2026
…ifacts (#86)

* fix(deploy): pass image-digest + ssh/kubeconfig secrets to stg/prd

Addresses 4 CRITICAL issues from #82:

1. image-digest not threaded — stg.yml/prd.yml built deploy refs as
   "registry/owner/name@" + empty string, every deploy failed silently.
2. stg-image-digest + stg-deploy-time not threaded to prd — the
   observation-window safety gate was a no-op; production could ship
   without staging verification.
3. ssh-key-stg / ssh-key-prd not forwarded — docker (default) deploy
   preflight aborts without them.
4. kubeconfig-prd not forwarded — k8s deploy mode aborts without it.

## Plumbing

- Added 3 new workflow_dispatch inputs (image-digest, stg-image-digest,
  stg-deploy-time) so manual deploys take an explicit digest.
- workflow_run paths read vars.LAST_*_IMAGE_DIGEST / LAST_STG_DEPLOY_TIME
  with empty fallbacks. Upstream ci.yml / stg deploy is expected to write
  these on success — that wiring is a follow-up since GHA doesn't directly
  expose nested workflow outputs across workflow_run boundaries.
- Forwarded the full set of secrets each reusable declares
  (kubeconfig-stg, ssh-key-stg in stg; kubeconfig-prd, ssh-key-prd in
  prd) by mapping repo UPPER_SNAKE to reusable kebab-case.

Refs #82

* chore: gitignore Claude runtime artifacts + add harness parity plan

- Add .claude/{worktrees,scheduled_tasks.lock,agents,projects,todos}
  to .gitignore so per-developer Claude Code state doesn't leak into
  the repo.
- Add docs/superpowers/plans/2026-05-02-claude-harness-param-parity.md
  documenting the planned upstream parameter parity work for the
  _common/claude-harness wrapper.

* fix(bump-sha): backfill missing PR + supersede stale bump branches

The on-main-bump-sha workflow silently failed at `gh pr create
--label "chore"` because no `chore` label exists in the repo, and
`2>/dev/null || true` swallowed the error. Result: the workflow
pushed bump branches (e.g. chore/bump-self-sha-89792333) without
opening a PR, and stale orphan branches accumulated.

Changes:
- Drop the non-existent `chore` label from `gh pr create`.
- Remove the `2>/dev/null || true` so future PR-creation errors
  surface and fail the workflow.
- `set -euo pipefail` on the run block.
- Switch to `git checkout -B` + `git push --force-with-lease` so
  workflow re-runs on the same SHA are idempotent instead of
  failing on existing branch.
- After pushing the new branch, close older `chore/bump-self-sha-*`
  PRs against `main` with `--delete-branch` so only the latest
  bump PR is open at any time.
- Sweep orphan `chore/bump-self-sha-*` branches that never got a
  PR (the exact failure mode that just happened) and delete them.
- Make `gh pr create` idempotent: if a PR already exists for the
  branch, log and skip instead of erroring.

* fix(workflows): satisfy audit tests inherited from main

The workflow audit added in #84-era (commit 4415cb2) introduced bats
tests that were already failing on main when authored:

- `reusable workflow names match filenames` — `name:` field in
  `reusable-agent.yml` (claude-harness) and `reusable-deps.yml`
  (dep-auto-merge) didn't reference the filename suffix.
- `workflow requests security-events: write permission` —
  `ci-self-test.yml` permissions block was missing
  `security-events: write`.
- `auditor is clean against the live repository` —
  workflow-audit.sh rule W03 flagged `reusable-release.yml` for
  redeclaring the caller's `concurrency.group` (deadlock risk per
  issue #68).

Fixes:
- Rename `name:` to `reusable-agent` / `reusable-deps`.
- Add `security-events: write` to ci-self-test.yml permissions.
- Drop the `concurrency:` block from `reusable-release.yml` and
  leave the caller (release.yml) as the sole owner of the group.

All 719 bats tests now pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant